Update manually generated reference for RenderTreeFrame #13522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
added
the
ask-mode
mkArtakMSFT
added
the
area-mvc
rynowak
reviewed
Aug 28, 2019
| namespace Microsoft.AspNetCore.Components.RenderTree | ||
| { | ||
| // https://github.com/dotnet/arcade/pull/2033 | ||
| [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Explicit)] | ||
| [StructLayout(LayoutKind.Explicit, Pack = 4)] |
There was a problem hiding this comment.
Are the changes here to make this more like the authoritative source code?
There was a problem hiding this comment.
I used the source code as is and stripped it to the public API surface. Maintaining the code-generated format seems needlessly onerous.
rynowak
approved these changes
Aug 29, 2019
SteveSandersonMS
approved these changes
Aug 29, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13504
Description
The reference assembly for one of the of the types in Blazor is manually generated. We missed updating this as part of preview8 when there were API changes to the type A user discovered and reported this.
Customer impact
Customers may get MissingMethodException at runtime if they compile against type in the ref assembly.
Regression
It's a regression since preview8
Risk
Low. This is changes to a ref assembly. We do not have automated tests to verify that the ref assembly is correct, but I verified it manually.